Skip to content

Conversation

@daniel-rossier
Copy link
Contributor

No description provided.

@daniel-rossier daniel-rossier self-assigned this Aug 28, 2025
@daniel-rossier daniel-rossier linked an issue Aug 28, 2025 that may be closed by this pull request
@daniel-rossier
Copy link
Contributor Author

@AndreCostaaa Actually, we still have this issue of clang formatting. It has to stay as it is, but the CI doesn't accept it.
Please can you try to figure out?

@AndreCostaaa
Copy link
Contributor

AndreCostaaa commented Aug 28, 2025

Our clang-format rules don't play well with assembly code, for now I suggest telling it to ignore that part of the file with

/* clang-format off */
< Ignored by clang-format >
/* clang-format on */

@daniel-rossier
Copy link
Contributor Author

It is exactly what I was looking for :-) thanks André!

@daniel-rossier
Copy link
Contributor Author

@AndreCostaaa I think we're good to merge.

Copy link
Contributor

@AndreCostaaa AndreCostaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks good

@daniel-rossier daniel-rossier merged commit a454a18 into main Aug 28, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean clang formatted assembly declaration in a .h

3 participants