Skip to content

Conversation

@CarterSmarty
Copy link
Contributor

No description provided.

@EmeraldPandaTurtle
Copy link
Contributor

EmeraldPandaTurtle commented Oct 15, 2025

Looks pretty good

Some bad practices that should be avoided though

if !self.options.custom_queries.is_none() {
    for (key, value) in self.options.custom_queries.clone().unwrap() {
        builder = builder.query(&[(key, value)]);
    }
}

Should instead follow pattern matching so it should be

if let Some(queries) = self.options.custom_queries.cloned() {
    for (key, value) in queries {
        builder = builder.query(&[(key, value)]);
    }
}

We should probably rethink the name for with_custom_comma_separated_query to instead be something like with_appended_query_item, and change the doc comment to better describe the result. It's just a little vague.

Otherwise looks good to me.

@RyanLCox1 RyanLCox1 merged commit 3806d2c into master Oct 17, 2025
@RyanLCox1 RyanLCox1 deleted the carter/custom-query branch October 17, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants