Skip to content

Conversation

@KowalczykBartek
Copy link
Contributor

No description provided.

@emaxerrno
Copy link
Collaborator

@KowalczykBartek - Instead of committing straight into master. We should give other ppl the chance to make comments.

For example, this PR is missing a change in the fmt.py to add .java to the is_clang file.

Instead this should be a shell script and we should add it to the git ignore.

i.e.:

#!/bin/bash
set -ex
# step 1 get the script:
git_root=$(git rev-parse --show-toplevel)
if [[ ! -e "${git_root}/fmt.py"]]; then
   curl https://raw.githubusercontent.com/smfrpc/smf/master/tools/fmt.py -O "${git_root}/fmt.py"
fi
#exec it
python3 fmt.py 

and add fmt.py to the gitignore via

echo "fmt.py" >> .gitignore

This would do 2 things:

  1. it would keep the fmt consistent w/ the upstream parent, so we only change it one place
  2. give a heads up to other possible maintainers to voice opinion.

I think you should feel free to merge the PR (w/ rebase) into master after you give folks a bit of time to make comments.

@emaxerrno emaxerrno mentioned this pull request Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants