Skip to content

Conversation

@wangerekaharun
Copy link
Member

@wangerekaharun wangerekaharun commented Sep 11, 2025

User description

Story: https://app.shortcut.com/smileid/story/xxx

Summary

A few sentences/bullet points about the changes

Known Issues

Any shortcomings in your work. This may include corner cases not correctly handled or issues related
to but not within the scope of your PR. Design compromises should be discussed here if they were not
already discussed above.

Test Instructions

Concise test instructions on how to verify that your feature works as intended. This should include
changes to the development environment (if applicable) and all commands needed to run your work.

Screenshot

If applicable (e.g. UI changes), add screenshots to help explain your work.


PR Type

Enhancement


Description

  • Update SmileID Android SDK from v11.1.0 to v11.1.1

  • Add separate Android attestation dependency with exclusion

  • Fix prepUpload API call to include headers parameter

  • Increment Flutter SDK version to 11.2.1


File Walkthrough

Relevant files
Dependencies
build.gradle.kts
Update Android SDK dependencies and attestation                   

android/build.gradle.kts

  • Update SmileID Android SDK dependency from v11.1.0 to v11.1.1
  • Add exclusion for attestation module from main SDK
  • Add separate android-attestation dependency v11.1.1
+5/-1     
Bug fix
SmileIDPlugin.kt
Fix prepUpload API call with headers                                         

android/src/main/kotlin/com/smileidentity/flutter/SmileIDPlugin.kt

  • Fix prepUpload method call to include headers parameter
  • Add empty headers map as required parameter
+1/-1     
Documentation
CHANGELOG.md
Add changelog for v11.2.1 release                                               

CHANGELOG.md

  • Add changelog entry for version 11.2.1
  • Document Android SDK bump to v11.1.1
+5/-0     
Configuration changes
pubspec.yaml
Bump Flutter SDK version to 11.2.1                                             

pubspec.yaml

  • Increment Flutter SDK version from 11.2.0 to 11.2.1
+1/-1     


Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @prfectionist
    Copy link
    Contributor

    prfectionist bot commented Sep 11, 2025

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Empty Headers

    The prepUpload API call now passes an empty headers map. This change should be validated to ensure it doesn't break existing functionality or if specific headers are required for proper operation.

    work = { SmileID.api.prepUpload(headers = mapOf(), request = request.toRequest()).toResponse() },
    Dependency Structure

    The Android SDK dependency structure has changed to exclude attestation module and add it separately. This architectural change should be verified to ensure proper functionality and no conflicts between the modules.

    implementation("com.smileidentity:android-sdk:11.1.1") {
        exclude(group = "SmileID", module = "attestation")
    }
    implementation("com.smileidentity:android-attestation:11.1.1")

    @prfectionist
    Copy link
    Contributor

    prfectionist bot commented Sep 11, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link
    Contributor

    @robin-smileid robin-smileid left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Works fine for me - did a smart selfie enrollment and biometric kyc enrollment.

    @wangerekaharun wangerekaharun merged commit 2938077 into main Sep 11, 2025
    6 checks passed
    @wangerekaharun wangerekaharun deleted the feat/update-android-sdk branch September 11, 2025 14:01
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants