Generate RestJson event stream implementation #323
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
previously approved these changes
Oct 23, 2024
JordonPhillips
force-pushed
the
high-level-aws-streams
branch
from
6b59641 to
c0d86bc
Compare
JordonPhillips
force-pushed
the
mega-event-streaming
branch
from
2f059c3 to
bb1946e
Compare
nateprewitt
reviewed
Oct 24, 2024
Contributor
nateprewitt
left a comment
nateprewitt
left a comment
There was a problem hiding this comment.
Looks good, approving since the test failures are related to the latest Smithy release and we had a clean run yesterday with no functional changes.
JordonPhillips
dismissed
nateprewitt’s stale review
The base branch was changed.
This updates generic event stream generation with recently introduced changes and also introduces the concrete implementation for RestJson. Testing for all of this will be done via protocol tests, and in the early days manual testing. Since a lot of this is effectively throwaway code, I was more liberal with type ignoring and using Any types than I otherwise would be. The request pipeline is going to be moving to pure python soon^tm, and the typing issues will be resolved at that time.
JordonPhillips
force-pushed
the
mega-event-streaming
branch
from
bb1946e to
950f00b
Compare
nateprewitt
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates generic event stream generation with recently introduced changes and also introduces the concrete implementation for RestJson.
Testing for all of this will be done via protocol tests, and in the early days manual testing.
Since a lot of this is effectively throwaway code, I was more liberal with type ignoring and using Any types than I otherwise would be. The request pipeline is going to be moving to pure python soon^tm, and the typing issues will be resolved at that time.
This depends on #322
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.