Add design for codecs and client protocols #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
force-pushed
the
deser-design
branch
from
7152431 to
94ed292
Compare
JordonPhillips
force-pushed
the
higher-level-protocols
branch
2 times, most recently
from
4214d1e to
668627c
Compare
mtdowling
requested changes
Jan 29, 2025
JordonPhillips
force-pushed
the
deser-design
branch
2 times, most recently
from
fa0c97c to
fffa2cd
Compare
JordonPhillips
force-pushed
the
higher-level-protocols
branch
from
668627c to
5bdcfc5
Compare
JordonPhillips
force-pushed
the
higher-level-protocols
branch
from
5bdcfc5 to
10ef2f0
Compare
mtdowling
previously approved these changes
Feb 3, 2025
jonathan343
reviewed
Feb 18, 2025
jonathan343
reviewed
Feb 19, 2025
jonathan343
reviewed
Feb 19, 2025
jonathan343
previously approved these changes
Feb 19, 2025
JordonPhillips
dismissed stale reviews from jonathan343 and mtdowling
The base branch was changed.
JordonPhillips
force-pushed
the
higher-level-protocols
branch
from
10ef2f0 to
f338224
Compare
JordonPhillips
force-pushed
the
higher-level-protocols
branch
from
f338224 to
194de28
Compare
Contributor
Author
|
Had to rebase |
mtdowling
approved these changes
Feb 20, 2025
jonathan343
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds in the design for the higher level uses of serializers and deserializers - namely codecs and client protocols.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.