Await seek for AsyncIterable bodies #398
Merged
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
force-pushed
the
signer_seek_fix
branch
from
aa69cb7 to
71d48b4
Compare
jonathan343
previously approved these changes
Mar 3, 2025
nateprewitt
force-pushed
the
signer_seek_fix
branch
from
71d48b4 to
b438593
Compare
JordonPhillips
approved these changes
Mar 4, 2025
jonathan343
approved these changes
Mar 4, 2025
Contributor
jonathan343
left a comment
jonathan343
left a comment
There was a problem hiding this comment.
LGTM. I confirmed the following errors go away when applying these changes to the signer:
RuntimeWarning: coroutine 'SeekableAsyncBytesReader.seek' was never awaited
body.seek(position)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We are not properly awaiting the coroutine for
seekin the async signing implementation.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.