-
Notifications
You must be signed in to change notification settings - Fork 24
Sigv4 AuthScheme + Static/Environment Credentials Providers #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sigv4 AuthScheme + Static/Environment Credentials Providers #406
Conversation
...ges/smithy-aws-core/src/smithy_aws_core/credentials_resolvers/static_credentials_resolver.py
Show resolved
Hide resolved
| // This needs to be generated because there's modeled parameters that | ||
| // must be accounted for. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tragic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the alternative would be to add signingService as an auth param. We would then need a way to wire that up during the request. It could be an undocumented config property or have it somewhere else.
| ): | ||
| """SigV4 AuthScheme.""" | ||
|
|
||
| scheme_id: str |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| scheme_id: str | |
| scheme_id: Final = "aws.auth#sigv4" |
Well this should also be a ShapeID but that's probably a bit more involved to do just now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think we'd need to update the HttpAuthScheme protocol as well for that. I wasn't able to update this to Final without changing the HttpAuthScheme as well, which breaks with Final (since nothing is initialized on it).
For now, I've left the type as str but moved the initialization of it out of __init__
Description of changes:
Adds the Sigv4 AuthScheme to the AWS AuthIntegration and wires up the identity provider/auth params configs.
Generated Examples:
config.py:
auth.py:
client.py:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.