Fix AsyncBytesReader, read when bytes are already available #414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
previously approved these changes
Mar 10, 2025
Contributor
nateprewitt
left a comment
nateprewitt
left a comment
There was a problem hiding this comment.
This is a behavior we should probably have a test for to make sure it continues to work like we expect. Doesn't necessarily need to be done here but we should have an item to come back and write up tests for this read() impl.
JordonPhillips
previously approved these changes
Mar 10, 2025
Contributor
JordonPhillips
left a comment
JordonPhillips
left a comment
There was a problem hiding this comment.
+1 to adding a test
alextwoods
dismissed stale reviews from JordonPhillips and nateprewitt
via
f61e683
JordonPhillips
approved these changes
Mar 10, 2025
nateprewitt
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Output event streams were hanging when trying to read bytes from the AsyncBytesReader when
self._remainderalready had sufficient bytes to satisfy the read.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.