generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 24
Typed context #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Typed context #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
reviewed
Mar 11, 2025
82efcf8 to
6586745
Compare
7ed59fe to
4dc7504
Compare
haydenbaker
previously approved these changes
Mar 11, 2025
alextwoods
previously approved these changes
Mar 11, 2025
Contributor
alextwoods
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I like this. I'll put out an update to the UserAgent to use a typed property once this is merged :-)
This adds a typed properties bag, which is essentially a dict with some extra type forwarding built in.
a3d9316
4dc7504 to
a3d9316
Compare
Contributor
Author
|
Had to rebase |
alextwoods
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a typed context bag, which is essentially a dict with some extra type forwarding built in. It removes the need to pass around a bunch of
dict[str, Any]all over the place without sacrificing the ease that doing so provides.The intended use of this is to have statically defined typed properties, like so:
The property keys can then be shared so that nobody messes up the key or its typing, like we do in the code generator for symbol properties.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.