Decouple endpoint resolution from http #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haydenbaker
reviewed
Mar 19, 2025
codegen/core/src/main/java/software/amazon/smithy/python/codegen/PythonFormatter.java
Show resolved
Hide resolved
haydenbaker
previously approved these changes
Mar 19, 2025
alextwoods
suggested changes
Mar 19, 2025
codegen/aws/core/src/it/java/software/amazon/smithy/python/codegen/test/AwsCodegenTest.java
Show resolved
Hide resolved
codegen/core/src/main/java/software/amazon/smithy/python/codegen/ClientGenerator.java
Outdated
Show resolved
Hide resolved
JordonPhillips
force-pushed
the
no-http-endpoints
branch
from
ffa307e to
d6cd7dd
Compare
JordonPhillips
force-pushed
the
no-http-endpoints
branch
from
d6cd7dd to
3a67247
Compare
alextwoods
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decouples endpoint resolution from http. It does this by using the new
Endpointinterface that has a typed properties bag. HTTP endpoint providers MAY add a "headers" property that will be merged into the request's headers.The input of endpoint resolvers was simplified to be a standard param bundle that should contain anything they could possibly want. This includes the context properties for the invocation, so more stuff can be added there by interceptors. The config object is added as standard to the properties bag, but it's loosely typed since it's a generated type. The endpoint uri is added in a strongly typed way, though I had to play a bit fast and loose with pyright to get it to work with unions.
I also updated the formatting to remove unused imports because that makes the process of changing the default endpoint provider less painful.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.