Remove remaining references to smithy_event_stream #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
previously approved these changes
Mar 20, 2025
Contributor
nateprewitt
left a comment
nateprewitt
left a comment
There was a problem hiding this comment.
🤔 how is this working right now?
jonathan343
force-pushed
the
remove-smithy-event-stream
branch
from
d6dd273 to
7e76f6f
Compare
Contributor
Author
I'm not sure how everyone's been generating and using the client. I ran into this issue after pulling the latest from develop and trying to build a client. The pyproject.toml file in the generated repo still included a dependency on the |
nateprewitt
approved these changes
Mar 20, 2025
Contributor
|
It may be the old package was somehow accessible on the Python Path after it was removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #450, the
smithy_event_streampackage was removed and it's contents were centralized intosmithy_core. This PR removes all remaining references to this package.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.