Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "bugfix",
"description": "add port to CRT HTTP client's host header"
}
2 changes: 1 addition & 1 deletion packages/smithy-http/src/smithy_http/aio/crt.py
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ def _marshal_request(
headers_list: list[tuple[str, str]] = []
if "host" not in request.fields:
request.fields.set_field(
Field(name="host", values=[request.destination.host])
Field(name="host", values=[request.destination.netloc])
)

if "accept" not in request.fields:
Expand Down
21 changes: 21 additions & 0 deletions packages/smithy-http/tests/unit/aio/test_crt.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,27 @@ def test_client_marshal_request() -> None:
assert crt_request.path == "/path?key1=value1&key2=value2"


@pytest.mark.parametrize(
"host,expected",
[
("example.com", "example.com:8443"),
("2001:db8::1", "[2001:db8::1]:8443"),
],
)
async def test_port_included_in_host_header(host: str, expected: str) -> None:
client = AWSCRTHTTPClient()
request = HTTPRequest(
method="GET",
destination=URI(
host=host, path="/path", query="key1=value1&key2=value2", port=8443
),
body=BytesIO(),
fields=Fields(),
)
crt_request = client._marshal_request(request) # type: ignore
assert crt_request.headers.get("host") == expected # type: ignore


async def test_body_generator_bytes() -> None:
"""Test body generator with bytes input."""
client = AWSCRTHTTPClient()
Expand Down
Loading