Prepare release #604
Open
Prepare release #604
+112
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan343
requested changes
Nov 21, 2025
Contributor
There was a problem hiding this comment.
Thanks Sam! Left a few comments. You're missing a few steps for each package in this PR:
- We need to run
./scripts/new-release -p <package_name> -v <package_version> - Then run
./scripts/render -p <package_name> -o packages/<package_name>/CHANGELOG.md - Was not including the bumps in SmithyPythonDependency.java intentional? We need that to have new SDKs get generated with the new minor versions
...ws-event-stream/.changes/next-release/smithy-aws-event-stream-dependency-20251121101319.json
Outdated
Show resolved
Hide resolved
|
|
||
| __license__ = "Apache-2.0" | ||
| __version__ = "0.1.0" | ||
| __version__ = "0.2.0" |
Contributor
There was a problem hiding this comment.
Why does signers need a minor version bump? This is a leaf note in the dependency tree of the SDKs and smithy-aws-core. There are also no new changes being added to this package. Personally, I don't think we should be bumping this.
| from .interfaces import FieldPosition | ||
|
|
||
| __version__ = "0.2.1" | ||
| __version__ = "0.3.0" |
Contributor
There was a problem hiding this comment.
I feel like we may also want to have a changelong entry for #590. Not sure if that was a miss in the original PR or intentional.
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "type": "dependency", | |||
| "description": "Bump dependencies on smithy-core, smithy-http, and aws-sdk-signers for minor release" | |||
Contributor
There was a problem hiding this comment.
- This is missing bumps for
smithy-aws-event-streamandsmithy-json. - Definitely debatable, but personally, I think each should have their own entry using the format I provided in a different comment. They would eventually get rendered in the changelog as:
Dependencies
- Bump
smithy-corefrom~=0.1.0to~=0.2.0.- Bump
smithy-httpfrom~=0.2.0to~=0.3.0.- Bump
smithy-aws-event-streamfrom~=0.1.0to~=0.2.0.- Bump
smithy-jsonfrom~=0.1.0to~=0.2.0.
…aws-event-stream-dependency-20251121101319.json Co-authored-by: jonathan343 <43360731+jonathan343@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare release of standard retry mode and add minor version bumps for it
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.