Skip to content

fix: use a linked set instead of a normal set #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dayaffe merged 4 commits into from
Nov 25, 2025
Merged

fix: use a linked set instead of a normal set #1005

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7369f51
use a list instead of set to fix flake
dayaffe Nov 25, 2025
9675e77
Merge branch 'main' into day/fixing-stuff
dayaffe Nov 25, 2025
764bd92
keep some as set
dayaffe Nov 25, 2025
7ceb663
Merge branch 'main' into day/fixing-stuff
dayaffe Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions smithy-swift-codegen/src/main/kotlin/software/amazon/smithy/swift/codegen/SwiftSettings.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ private const val GENERATE_DEPENDENCY_JSON = "generateDependencyJSON"

// Prioritized list of protocols supported for code generation
private val DEFAULT_PROTOCOL_RESOLUTION_PRIORITY =
setOf<ShapeId>(
listOf<ShapeId>(
Rpcv2CborTrait.ID,
AwsJson1_0Trait.ID,
AwsJson1_1Trait.ID,
Expand Down Expand Up @@ -212,7 +212,7 @@ class SwiftSettings(
serviceIndex: ServiceIndex,
service: ServiceShape,
supportedProtocolTraits: Set<ShapeId>,
configuredProtocolPriority: Set<ShapeId>? = null,
configuredProtocolPriority: List<ShapeId>? = null,
): ShapeId {
val resolvedProtocols: Set<ShapeId> = serviceIndex.getProtocols(service).keys

Expand Down
Loading