add initial stream bridge #964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dayaffe
commented
Sep 16, 2025
Sources/ClientRuntime/Networking/Http/NIO/NIOHTTPClientStreamBridge.swift
Outdated
Show resolved
Hide resolved
jbelkins
requested changes
Sep 23, 2025
There was a problem hiding this comment.
A couple questions inline.
I also think we should have tests around this stream bridge, for an example see:
https://github.com/smithy-lang/smithy-swift/blob/main/Tests/ClientRuntimeTests/NetworkingTests/URLSession/FoundationStreamBridgeTests.swift
Sources/ClientRuntime/Networking/Http/NIO/NIOHTTPClientStreamBridge.swift
Outdated
Show resolved
Hide resolved
Sources/ClientRuntime/Networking/Http/NIO/NIOHTTPClientStreamBridge.swift
Show resolved
Hide resolved
Sources/ClientRuntime/Networking/Http/NIO/NIOHTTPClientStreamBridge.swift
Outdated
Show resolved
Hide resolved
jbelkins
requested changes
Sep 24, 2025
Sources/ClientRuntime/Networking/Http/NIO/NIOHTTPClientStreamBridge.swift
Show resolved
Hide resolved
Tests/ClientRuntimeTests/NetworkingTests/Http/NIO/NIOHTTPClientStreamBridgeTests.swift
Outdated
Show resolved
Hide resolved
jbelkins
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.