[WIP]fix: not to override path and query from serializer #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZhengYP
force-pushed
the
fix-request-defaults
branch
from
6a7575f to
294948e
Compare
kstich
reviewed
Apr 24, 2020
| HttpProtocolGeneratorUtils.writeHostPrefix(context, operation); | ||
| } | ||
|
|
||
| writer.write("const endpoint = {...context.endpoint, path: undefined, query: undefined};"); |
Contributor
There was a problem hiding this comment.
Can you add comments to these lines explaining why the indirection is necessary?
AllanZhengYP
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is WIP
Fix a bug introduced in #158. By default the parsed endpoint will have a default
path:/, which will then incorrectly override the path from operation model. By this change, the default endpoint or endpoint supplied from client constructor can only override thehostname,protocol, andportpart of the request. Whereaspathandquerywill always be generated from the model. This behavior will also be align with V2 SDK.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.