chore: schema code size optimization #1681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
force-pushed
the
schema/optimization
branch
5 times, most recently
from
82198a7 to
ac5d7d3
Compare
kuhe
force-pushed
the
schema/optimization
branch
from
ac5d7d3 to
64b312c
Compare
kuhe
commented
Sep 4, 2025
| */ | ||
| public constructor( | ||
| private readonly ref: SchemaRef, | ||
| private constructor( |
There was a problem hiding this comment.
alpha API breaking change: the only public constructor is now the static constructor.
| * Static constructor that attempts to avoid wrapping a NormalizedSchema within another. | ||
| */ | ||
| public static of(ref: SchemaRef, memberName?: string): NormalizedSchema { | ||
| public static of(ref: SchemaRef): NormalizedSchema { |
There was a problem hiding this comment.
alpha API breaking change: static public ctor no longer allows a member name.
Members must not be initialized on their own. They must be retrieved as part of an aggregate schema (struct, union, list, map, document etc.).
This simplifies reasoning about the schema data that is present.
kuhe
force-pushed
the
schema/optimization
branch
from
113efff to
3b3ccc7
Compare
kuhe
force-pushed
the
schema/optimization
branch
from
3b3ccc7 to
dea7bd9
Compare
smilkuri
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.