Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,10 @@
* bear: (value: Bear) => T;
* _: (name: string, value: any) => T;
* }
* export function visit<T>(
* export const visit = <T>(
* value: Attacker,
* visitor: Visitor<T>
* ): T {
* ): T => {
* if (value.lion !== undefined) return visitor.lion(value.lion);
* if (value.tiger !== undefined) return visitor.tiger(value.tiger);
* if (value.bear !== undefined) return visitor.bear(value.bear);
Expand Down Expand Up @@ -193,10 +193,10 @@ private void writeVisitorType() {

private void writeVisitorFunction() {
// Create the visitor dispatcher for the union.
writer.write("export function visit<T>(").indent();
writer.write("export const visit = <T>(").indent();
writer.write("value: $L,", symbol.getName());
writer.write("visitor: Visitor<T>");
writer.dedent().write("): T {").indent();
writer.dedent().write("): T => {").indent();
for (MemberShape member : shape.getAllMembers().values()) {
String memberName = symbolProvider.toMemberName(member);
writer.write("if (value.${1L} !== undefined) return visitor.$1L(value.${1L});", memberName);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,10 @@ public void generatesTaggedUnions() {
+ " }"));

// It generates the actual visitor function.
assertThat(output, containsString("export function visit<T>(\n"
assertThat(output, containsString("export const visit = <T>(\n"
+ " value: Example,\n"
+ " visitor: Visitor<T>\n"
+ " ): T {\n"
+ " ): T => {\n"
+ " if (value.A !== undefined) return visitor.A(value.A);\n"
+ " if (value.B !== undefined) return visitor.B(value.B);\n"
+ " if (value.C !== undefined) return visitor.C(value.C);\n"
Expand Down