Skip to content

Conversation

@kuhe
Copy link
Contributor

@kuhe kuhe commented Nov 14, 2025

I noticed that if you define a property as undefined and then call Object.defineProperty on it with only a value, it no longer default to non-enumerable.

The ServiceException (base class) from @smithy/client has:

export class ServiceException extends Error implements SmithyException, MetadataBearer {
  readonly $fault: "client" | "server";
  $response?: HttpResponse;

which creates a class instance level key that is undefined.

@kuhe kuhe requested a review from a team as a code owner November 14, 2025 19:19
@kuhe kuhe merged commit e659a06 into main Nov 14, 2025
13 checks passed
@kuhe kuhe deleted the fix/metadata branch November 14, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants