Skip to content

Conversation

@trivikr
Copy link
Contributor

@trivikr trivikr commented Apr 13, 2021

Issue #, if available:
Follow-up to #257

Description of changes:

  • Regular expression used for search: context.getModel\(\)\.getKnowledge\(([^\.]*).class\) replaced with $1.of(context.getModel())
  • Verified that there are no more getKnowledge calls

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Regular expression uses for search:
`context.getModel\(\)\.getKnowledge\(([^\.]*).class\)` replaced with
`$1.of(context.getModel())`
@trivikr trivikr merged commit 2484093 into smithy-lang:main Apr 13, 2021
@trivikr trivikr deleted the remove-missing-getKnowledge-calls branch April 13, 2021 14:57
srchase pushed a commit to srchase/smithy-typescript that referenced this pull request Mar 17, 2023
…ng#309)

Regular expression uses for search:
`context.getModel\(\)\.getKnowledge\(([^\.]*).class\)` replaced with
`$1.of(context.getModel())`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants