Centralize all global state into a single structure #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but it seems that CI is failing. |
|
Yeah it looks like there's a condition where a notification is dropped, for some reason. I can replicate this about 1 in 10 times on my local machine. Will investigate. |
There was a panic where the reaper thread tried to access the OnceCell before it was initialized. This was fixed by using wait_blocking() instead of get().unwrap() Signed-off-by: John Nunley <dev@notgull.net>
notgull
force-pushed
the
notgull/reaper
branch
from
975c2e2 to
739703a
Compare
Signed-off-by: John Nunley <dev@notgull.net>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how
async-iohas most of its global state in theReactorstructure, this PR sets it up so that all of this crate's global state is contained in a singleReaperstructure instead of being scattered about.