Remove the pre-exec extension function #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't replicate the test failures on my machine, even with: for i in $(seq 0 1000); do
cargo test
done |
taiki-e
approved these changes
Oct 5, 2023
|
Thanks for the review! I'd rather merge #56 before we have a breaking change blocked on master. |
The purpose for removing this function is twofold: - It is the only unsafe code in this crate that can't be realistically replaced with safe code. - It is a footgun anyways, and can be done anyways with Into::into() if users really want it. This is a breaking change. Signed-off-by: John Nunley <dev@notgull.net>
notgull
force-pushed
the
notgull/no-pre-exec
branch
from
f2bfaab to
558bf2a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose for removing this function is twofold:
This is a breaking change.