Merge renderChildren() and renderHTMLChildren()

Summary: `renderChildren()` now returns array which isn't ideal but I prefer it to having two methods.

Test Plan: None.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4910

Author: vrana

src/applications/differential/view/DifferentialChangesetDetailView.php

@@ -101,7 +101,7 @@ public function render() {
           $buttons,
           phutil_tag('h1', array(), $display_filename),
           phutil_tag('div', array('style' => 'clear: both'), ''),
-          $this->renderHTMLChildren(),
+          $this->renderChildren(),
         )));
   }
 

src/applications/differential/view/DifferentialInlineCommentEditView.php

@@ -123,7 +123,7 @@ private function renderBody() {
       array(
         'class' => 'differential-inline-comment-edit-body',
       ),
-      $this->renderHTMLChildren());
+      $this->renderChildren());
 
     $edit = phutil_tag(
       'edit',

src/applications/differential/view/DifferentialPrimaryPaneView.php

@@ -17,7 +17,7 @@ public function render() {
         'class' => 'differential-primary-pane',
         'id'    => $this->id,
       ),
-      $this->renderHTMLChildren());
+      $this->renderChildren());
   }
 
 }

src/applications/feed/view/PhabricatorFeedStoryView.php

@@ -89,7 +89,7 @@ public function render() {
         array(
           'class' => 'phabricator-feed-story-body',
         ),
-        phutil_safe_html($this->renderChildren()));
+        phutil_safe_html(implode('', $this->renderChildren())));
 
       if ($this->epoch) {
         $foot = phabricator_datetime($this->epoch, $this->user);

src/applications/ponder/view/PonderVotableView.php

@@ -85,7 +85,7 @@ public function render() {
           array(
             'class' => 'ponder-votebox-content',
           ),
-          $this->renderHTMLChildren()),
+          $this->renderChildren()),
       ));
   }
 

src/applications/uiexample/examples/JavelinViewExampleServerView.php

@@ -8,7 +8,7 @@ public function render() {
       array(
         'class' => 'server-view',
       ),
-      $this->renderHTMLChildren());
+      $this->renderChildren());
   }
 
 }

src/docs/developer/rendering_html.diviner

@@ -124,14 +124,6 @@ return `phutil_tag()` or `javelin_tag()`:
 
   return phutil_tag('div', ...);
 
-@{class:AphrontView} subclasses can use `renderHTMLChildren()` and
-`renderSingleView()` to build @{class@libphutil:PhutilSafeHTML} objects from
-children or arbitrary lists of components.
-
-@{class:AphrontView} subclasses should avoid `renderChildren()` and transition
-callers to `renderHTMLChildren()`. This older method does not return
-@{class@libphutil:PhutilSafeHTML} objects.
-
 = Internationalization: pht() =
 
 The @{function:pht} function has some special rules. If any input to

src/view/AphrontDialogView.php

@@ -158,7 +158,7 @@ final public function render() {
     }
 
     $buttons[] = phutil_tag('div', array('style' => 'clear: both;'), '');
-    $children = $this->renderHTMLChildren();
+    $children = $this->renderChildren();
 
     $content = hsprintf(
       '%s%s%s',

src/view/AphrontJavelinView.php

@@ -32,7 +32,7 @@ public function render() {
       'id' => $id,
       'view' => $this->getName(),
       'params' => $this->getParameters(),
-      'children' => $this->renderChildren(),
+      'children' => implode('', $this->renderChildren()),
       'trigger_id' => $render_context,
     ));
 

src/view/AphrontNullView.php

@@ -3,7 +3,7 @@
 final class AphrontNullView extends AphrontView {
 
   public function render() {
-    return $this->renderHTMLChildren();
+    return phutil_implode_html('', $this->renderChildren());
   }
 
 }