Skip to content

Adjust the theme to fix some dark mode issues #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Adjust the theme to fix some dark mode issues #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37bc43a
Fix theming
Fabtron Jul 23, 2024
5de9c6f
change to app compat imageview to make dark mode work
Fabtron Jul 23, 2024
25683bf
change to app compat imageview to make dark mode work and roll back o…
Fabtron Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions ui/src/main/res/drawable/snabble_ic_plus.xml
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions ui/src/main/res/layout/snabble_dialog_product_confirmation.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,12 @@
android:layout_height="wrap_content"
android:layout_marginEnd="8dp">

<ImageView
<androidx.appcompat.widget.AppCompatImageView
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="center"
android:importantForAccessibility="no"
android:src="@drawable/snabble_ic_minus"
android:src="@drawable/snabble_ic_minus_content"
app:tint="?attr/colorOnSurface" />

<com.google.android.material.button.MaterialButton
Expand Down Expand Up @@ -145,12 +145,12 @@
android:layout_height="wrap_content"
android:layout_marginStart="8dp">

<ImageView
<androidx.appcompat.widget.AppCompatImageView
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_gravity="center"
android:importantForAccessibility="no"
android:src="@drawable/snabble_ic_plus"
android:src="@drawable/snabble_ic_plus_content"
app:tint="?attr/colorOnSurface" />

<com.google.android.material.button.MaterialButton
Expand Down
4 changes: 2 additions & 2 deletions ui/src/main/res/layout/snabble_view_checkout_bar.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
tools:src="@drawable/snabble_ic_payment_select_sepa"
android:importantForAccessibility="no" />

<ImageView
<androidx.appcompat.widget.AppCompatImageView
android:id="@+id/payment_chevron"
android:layout_width="7dp"
android:layout_height="7dp"
Expand Down Expand Up @@ -129,4 +129,4 @@
android:layout_marginTop="12dp"
android:layout_marginBottom="12dp"
android:text="@string/Snabble.Shoppingcart.BuyProducts.selectPaymentMethod" />
</merge>
</merge>
4 changes: 2 additions & 2 deletions ui/src/main/res/values/styles.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,11 @@
</style>

<style name="Widget.App.SnackbarText" parent="Widget.MaterialComponents.Snackbar.TextView">
<item name="android:textColor">?attr/colorOnSurface</item>
<item name="android:textColor">?attr/colorOnSecondaryContainer</item>
</style>

<style name="ThemeOverlay.App.Snackbar" parent="">
<item name="colorOnSurface">?attr/colorSurface</item>
<item name="colorOnSurface">?attr/colorSecondaryContainer</item>
</style>

</resources>