Fix recovery chooser trigger on NUC#97
Merged
valentindavid merged 1 commit intocanonical:mainfrom Jun 30, 2022
Merged
Conversation
Member
alfonsosanchezbeato
left a comment
alfonsosanchezbeato
left a comment
There was a problem hiding this comment.
Looks good, just have a question below.
Member
|
This can leverage the change to include modules without adding to modules.d that has been just merged. |
We need to chroot when switching root, so we send SIGUSR1 to recovery chooser trigger. We need to load all hid drivers. We should not load them into the kernel though.
valentindavid
force-pushed
the
valentindavid/nuc-fix
branch
from
3f801b3 to
9d81012
Compare
alfonsosanchezbeato
approved these changes
Jun 20, 2022
Member
alfonsosanchezbeato
left a comment
alfonsosanchezbeato
left a comment
There was a problem hiding this comment.
LGTM! Do we need the change in snapd released to merge this?
Member
Author
Yes. We need canonical/snapd#11742 which is merged. Not sure if it was released. But the thing is just broken. So not having the updated snapd does not make it any more broken with that one merged. |
valentindavid
added a commit
to valentindavid/snapd
that referenced
this pull request
Jul 31, 2024
core-initrd for UC20 is missing the following fixes: * canonical/core-initrd#64 * canonical/core-initrd#70 * canonical/core-initrd#97 Because of that, it still kills recovery-chooser-trigger from initrd, and expects it to re-run from snapd snap. Until those fixes are backported, we need to keep on building snap-bootstrap. This is not needed by UC22+
ernestl
pushed a commit
to canonical/snapd
that referenced
this pull request
Aug 2, 2024
core-initrd for UC20 is missing the following fixes: * canonical/core-initrd#64 * canonical/core-initrd#70 * canonical/core-initrd#97 Because of that, it still kills recovery-chooser-trigger from initrd, and expects it to re-run from snapd snap. Until those fixes are backported, we need to keep on building snap-bootstrap. This is not needed by UC22+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to chroot when switching root, so we send SIGUSR1 to recovery
chooser trigger.
We need to load all hid drivers. We should not load them into the
kernel though.
This works with canonical/snapd#11742