Merged
Conversation
kyrofa
reviewed
Nov 1, 2016
| enum: | ||
| - explicit | ||
| license-version: | ||
| description: license version (used to re-trigger an agreement action). |
Contributor
There was a problem hiding this comment.
Won't removing this from the schema cause the snapcraft.yamls out there that are using this to actually break? What if we left them along with the deprecation warning, but rephrased the deprecation warning to say "this doesn't actually do anything anymore"?
Contributor
Author
There was a problem hiding this comment.
Yeah, what a horrible world to live in :-/
Contributor
There was a problem hiding this comment.
On the bright side, once we can deliver as a snap we can jump major version numbers without worrying about SRUs.
Contributor
Author
There was a problem hiding this comment.
I don't think we need a warning, this should be a flat out breakage as if not it would create the expectation that it works when it clearly doesn't
LP: #1638303 Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
sergiusens
force-pushed
the
bugfix/1638303/license--
branch
from
bd290cd to
7d313e5
Compare
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Apr 6, 2017
LP: #1638303 Signed-off-by: Sergio Schvezov <sergio.schvezov@ubuntu.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LP: #1638303
Signed-off-by: Sergio Schvezov sergio.schvezov@ubuntu.com