snapenv: add environment variable with UID value#12565
Merged
mvo5 merged 11 commits intocanonical:masterfrom Mar 28, 2023
Merged
snapenv: add environment variable with UID value#12565mvo5 merged 11 commits intocanonical:masterfrom
mvo5 merged 11 commits intocanonical:masterfrom
Conversation
sergio-costas
changed the title
sergio-costas
force-pushed
the
add_user_id_environment_variable
branch
from
169f491 to
69b62fe
Compare
ernestl
previously approved these changes
Feb 16, 2023
Contributor
|
This needs to define a matching assume (snap-uid perhaps)?, see o/snapstate/check_snap.go, as a snap using this, especially directly from the snap.yaml running on a old snapd would usually fail without ways to fallback so we need to way to prevent it installing early |
pedronis
added
the
Needs Samuele review
sergio-costas
force-pushed
the
add_user_id_environment_variable
branch
from
8516bfd to
a8e4767
Compare
Contributor
Author
|
@pedronis Good point! Added. |
pedronis
reviewed
Mar 2, 2023
pedronis
added
Needs Documentation 📖
Needs security review
pedronis
reviewed
Mar 3, 2023
Contributor
pedronis
left a comment
pedronis
left a comment
There was a problem hiding this comment.
this looks alright in itself, I asked though security to review to see if they can chime in about a proper comment on the usage of euid
Contributor
Author
|
About the "needs documentation" tag... where should I send a patch to include that? |
Member
|
sergio-costas
force-pushed
the
add_user_id_environment_variable
branch
2 times, most recently
from
bb2d3a7 to
6cd271b
Compare
sergio-costas
force-pushed
the
add_user_id_environment_variable
branch
2 times, most recently
from
53c053c to
b816223
Compare
sergio-costas
requested review from
pedronis
and removed request for
jhenstridge
pedronis
reviewed
Mar 15, 2023
pedronis
reviewed
Mar 15, 2023
Some ENVs require the user ID, but the only way of getting it is using a little shell script that exports the ENV after using "id -u" to get the value. Other uses tricks, like taking advantage of a similar path (like firefox, which sets PULSE_SERVER to "$XDG_RUNTIME_DIR/../pulse/native". This patch adds the SNAP_UID environment variable, which contains the effective user id. With that, it's possible to define paths containing it directly in the YAML file.
sergio-costas
force-pushed
the
add_user_id_environment_variable
branch
from
9ae6c40 to
5df0079
Compare
pedronis
approved these changes
Mar 20, 2023
Contributor
Author
|
Commented in the documentation thread the new variables. https://forum.snapcraft.io/t/environment-variables/7983/28?u=sergiocostas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some ENVs require the user ID, but the only way of getting it is using a little shell script that exports the ENV after using "id -u" to get the value. Other uses tricks, like taking advantage of a similar path (like firefox, which sets PULSE_SERVER to "$XDG_RUNTIME_DIR/../pulse/native".
This patch adds the SNAP_UID environment variable, which contains the effective user id. With that, it's possible to define paths containing it directly in the YAML file.