interfaces: add seccomp support for hooks. #1374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add Spread tests to verify profile generation for both apps and hooks. Updates: #1586465 Signed-off-by: Kyle Fazzari <kyle@canonical.com>
tests/seccomp-profiles/task.yaml
Outdated
|
|
||
| for profile in snap.basic-binaries.block snap.basic-binaries.cat snap.basic-binaries.echo snap.basic-binaries.fail snap.basic-binaries.success | ||
| do | ||
| [ -f "$seccomp_profile_directory/$profile" ] || exit 1 |
Contributor
There was a problem hiding this comment.
This test is duplicating the whole logic just to add this additional line, it seems? Can we just add this one line into the other test and rename it to security-profiles?
Contributor
Author
There was a problem hiding this comment.
Yep, you're right. Done.
Contributor
|
A note about test duplication and then LGTM. |
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Contributor
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More progress on LP: #1586465. Also add Spread tests to verify profile generation for both apps and hooks.