cmd: enable SNAP_REEXEC only if it is set to SNAP_REEXEC=1 #1772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
Collaborator
|
I suppose we need to rediscuss this all together, there are potential issues also not reexecing if the core is too old |
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we agreed to use the SRU process during the last sprint I would like to suggest that we disable the re-exec feature for now by default.
This will fix the most recent issue with snapd and ubuntu-core from edge (https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1617890).
It also ensures that when we SRU 2.13 people actually use 2.13. Right now the 2.13 SRU re-execs to the version in ubuntu-core (which is 2.12 in stable) so we get less value out of the xenial-proposed testing than we could and should.
Other ideas are welcome of course!