ctlcmd: add snapctl get.#1983
Merged
Merged
Conversation
Currently snapd supports setting configuration values via `snapctl set`. Add the ability to obtain configuration values by addding `snapctl get`. Updates: #1596629 Signed-off-by: Kyle Fazzari <kyle@canonical.com>
niemeyer
approved these changes
Sep 23, 2016
| for _, key := range c.Positional.Keys { | ||
| var value interface{} | ||
| if err := transaction.Get(c.context().SnapName(), key, &value); err != nil { | ||
| return fmt.Errorf("cannot get configuration: %s", err) |
Contributor
There was a problem hiding this comment.
Do we need this prefix? Isn't the message returned implying that already?
Contributor
Author
There was a problem hiding this comment.
Yeah you're right-- removed.
|
|
||
| for _, key := range c.Positional.Keys { | ||
| var value interface{} | ||
| if err := transaction.Get(c.context().SnapName(), key, &value); err != nil { |
Contributor
There was a problem hiding this comment.
Might be good to lock the transaction, so we know all the values returned are consistent with each other (think of a concurrent set user/pass).
It's okay to address that in a follow up, as typically we won't see concurrency within a single hook.
Contributor
Author
There was a problem hiding this comment.
Hmm, yeah concurrent access within the same hook was not something I really considered. I think this will solve most use-cases, but we can follow up later with that.
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
Signed-off-by: Kyle Fazzari <kyle@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently snapd supports setting configuration values via
snapctl set. This PR makes more progress on LP: #1596629 by adding the ability to obtain configuration values viasnapctl get.