snap: use "SSO Password:" in the snap login prompt
#2298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids potential confusion with the sudo password prompt when `sudo snap login` is run. LP: #1637299
niemeyer
reviewed
Nov 17, 2016
cmd/snap/cmd_login.go
Outdated
|
|
||
| func requestLogin(email string) error { | ||
| fmt.Fprint(Stdout, i18n.G("Password: ")) | ||
| fmt.Fprint(Stdout, i18n.G("SSO Password: ")) |
Contributor
There was a problem hiding this comment.
How about "Store password: "?
Contributor
Author
There was a problem hiding this comment.
I like that! Much nicer than SSO password.
mvo5
force-pushed
the
bugfix/sso-password-prompt
branch
from
e6149be to
6af047e
Compare
Contributor
|
I came here to shout that SSO means nothing to anybody, but see that Gustavo already caught that one. Phew. However, how would somebody new know that "Store password" is not wanting a yes/no answer? Is there a reason "Ubuntu One password" is bad? |
Contributor
|
Good point about store being a verb as well. Not sure if this will create problems or not, but maybe we can think of something better. How about I was avoiding "Ubuntu One" in anticipation of custom stores. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids potential confusion with the sudo password prompt when
sudo snap loginis run.LP: #1637299