overlord/snapstate: support for pre-remove hook#6232
Closed
stolowski wants to merge 2 commits intocanonical:masterfrom
Closed
overlord/snapstate: support for pre-remove hook#6232stolowski wants to merge 2 commits intocanonical:masterfrom
stolowski wants to merge 2 commits intocanonical:masterfrom
Conversation
Contributor
Author
|
Marking blocked as the bug report and use case need further consideration. |
Contributor
Author
|
Closing for now, will re-open if we have clarity and decide to revive it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for
pre-removehook, executed before stop-snap-services (contrary toremovehook which runs later). This addresses https://bugs.launchpad.net/snapd/+bug/1777121Note, the case where pre-remove hook is not run at all is covered by existing test case (that checks no hooks were run on remove with 2 revisions), so not visible in the diff.