Skip to content

tests: enable debian sid as part of the main suite on travis#6406

Closed
sergiocazzolato wants to merge 10 commits intocanonical:masterfrom
sergiocazzolato:tests-enable-debian-sid
Closed

tests: enable debian sid as part of the main suite on travis#6406
sergiocazzolato wants to merge 10 commits intocanonical:masterfrom
sergiocazzolato:tests-enable-debian-sid

Conversation

@sergiocazzolato
Copy link
Copy Markdown
Contributor

No description provided.

@bboozzoo
Copy link
Copy Markdown
Contributor

Looks like we'd need to disable the unit tests on sid:

2019-01-21 20:42:07 Error executing google:debian-sid-64:tests/unit/go : 
-----
+ mkdir -p /tmp/static-unit-tests/src/github.com/snapcore
+ cp -ar /home/gopath/src/github.com/snapcore/snapd /tmp/static-unit-tests/src/github.com/snapcore
+ chown -R test:12345 /tmp/static-unit-tests
+ rm -r /tmp/static-unit-tests/src/github.com/snapcore/snapd/vendor/github.com/ /tmp/static-unit-tests/src/github.com/snapcore/snapd/vendor/golang.org/ /tmp/static-unit-tests/src/github.com/snapcore/snapd/vendor/gopkg.in/
+ rm -rf /tmp/static-unit-tests/src/github.com/snapcore/snapd/cmd/autom4te.cache /tmp/static-unit-tests/src/github.com/snapcore/snapd/cmd/configure /tmp/static-unit-tests/src/github.com/snapcore/snapd/cmd/test-driver /tmp/static-unit-tests/src/github.com/snapcore/snapd/cmd/config.status /tmp/static-unit-tests/src/github.com/snapcore/snapd/cmd/config.guess /tmp/static-unit-tests/src/github.com/snapcore/snapd/cmd/config.sub /tmp/static-unit-tests/src/github.com/snapcore/snapd/cmd/config.h.in /tmp/static-unit-tests/src/github.com/snapcore/snapd/cmd/compile /tmp/static-unit-tests/src/github.com/snapcore/snapd/cmd/install-sh /tmp/static-unit-tests/src/github.com/snapcore/snapd/cmd/depcomp /tmp/static-unit-tests/src/github.com/snapcore/snapd/cmd/build /tmp/static-unit-tests/src/github.com/snapcore/snapd/cmd/missing /tmp/static-unit-tests/src/github.com/snapcore/snapd/cmd/aclocal.m4 /tmp/static-unit-tests/src/github.com/snapcore/snapd/cmd/Makefile /tmp/static-unit-tests/src/github.com/snapcore/snapd/cmd/Makefile.in
+ su -l -c 'cd /tmp/static-unit-tests/src/github.com/snapcore/snapd && PATH=/home/gopath/bin:/snap/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/usr/lib/go-1.6/bin:/var/lib/snapd/snap/bin GOPATH=/tmp/static-unit-tests ./run-checks --static' test
Obtaining dependencies
Checking docs
Checking formatting
Formatting wrong in following files:
/tmp/static-unit-tests/src/github.com/snapcore/snapd/snap/gadget_test.go
/tmp/static-unit-tests/src/github.com/snapcore/snapd/progress/ansimeter_test.go
/tmp/static-unit-tests/src/github.com/snapcore/snapd/osutil/udev/netlink/uevent_test.go
/tmp/static-unit-tests/src/github.com/snapcore/snapd/osutil/udev/netlink/uevent_test.go
/tmp/static-unit-tests/src/github.com/snapcore/snapd/interfaces/policy/basedeclaration_test.go
/tmp/static-unit-tests/src/github.com/snapcore/snapd/interfaces/policy/basedeclaration_test.go
/tmp/static-unit-tests/src/github.com/snapcore/snapd/cmd/snap/cmd_run_test.go
/tmp/static-unit-tests/src/github.com/snapcore/snapd/cmd/snap/cmd_run_test.go
/tmp/static-unit-tests/src/github.com/snapcore/snapd/asserts/account_key_test.go

The static unit test fails with:
```
Formatting wrong in following files:
/tmp/static-unit-tests/src/github.com/snapcore/snapd/snap/gadget_test.go
/tmp/static-unit-tests/src/github.com/snapcore/snapd/progress/ansimeter_test.go
...
```
Probably because debian sid is using go 1.11. The regular unit tests
still run as part of the package building so in practise this just
disables the static checks on Debian Sid.
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #6406 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6406      +/-   ##
==========================================
+ Coverage   79.03%   79.04%   +<.01%     
==========================================
  Files         567      567              
  Lines       43975    43975              
==========================================
+ Hits        34755    34759       +4     
+ Misses       6400     6397       -3     
+ Partials     2820     2819       -1
Impacted Files Coverage Δ
overlord/ifacestate/handlers.go 63.51% <0%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 310d6e0...080cbbb. Read the comment docs.

Copy link
Copy Markdown
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should re-visit the journalctl.sh changes here. Everything else looks fine.


# WORKAROUND for memleak https://github.com/systemd/systemd/issues/11502
if [[ "$SPREAD_SYSTEM" == debian-sid* ]]; then
systemctl restart systemd-journald
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fun :)

@mvo5
Copy link
Copy Markdown
Contributor

mvo5 commented Jan 25, 2019

We may need to remove etckeeper from the image, I did that in #6413 and it helped to make things more reliable. Having said this, we probably also need to find out why etckeeper seems to badly interact with the apt hook we install from snapd.

@mvo5
Copy link
Copy Markdown
Contributor

mvo5 commented Feb 8, 2019

With 6413 being mergd we can close this one now.

@mvo5 mvo5 closed this Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants