i18n, vendor, packaging: drop github.com/ojii/gettext.go, use github.com/snapcore/go-gettext#7203
Merged
mvo5 merged 4 commits intocanonical:masterfrom Aug 27, 2019
Conversation
…napcore/go-gettext The original library has packaging problems (due to *.go suffix in directory) and is behind with fixes which are present in the snapcore fork. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
…pcore/go-gettext Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
…id-dependencies.patch Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Contributor
Author
|
Marked as blocked since golang-github-snapcore-gettext is not available in Fedora yet. |
Contributor
|
@bboozzoo I've sponsored you in as a packager in Fedora, so you should be able to proceed further. |
Contributor
|
@mvo5 This needs to be cherry-picked into 2.40, as it blocks my ability to update snapd in Fedora entirely. |
Contributor
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The github.com/ojii/gettext.go library causes various issues with Go tools. Because of the name ending with
*.go, Go tools are confused and the package is not go gettable. At the same time, the package has been dropped from Fedora, as the packaging infrastructure helpers break because of the import name.I am trying to get github.com/snapcore/go-gettext packaged for Fedora. The i18n support is disabled for Debian Sid. So we might as well just switch to using the snapcore fork.