snap/info: add Filename#8138
Merged
anonymouse64 merged 2 commits intocanonical:masterfrom Feb 14, 2020
Merged
Conversation
pedronis
requested changes
Feb 14, 2020
anonymouse64
force-pushed
the
feature/snap-revision-file-name
branch
from
0926036 to
6c7173a
Compare
This eliminates the need to call this snippet of code everywhere. It also eliminates some imports of path/filepath. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
anonymouse64
force-pushed
the
feature/snap-revision-file-name
branch
from
6c7173a to
4ddba7f
Compare
anonymouse64
changed the title
Contributor
Author
|
I also added just now a commit to wrap all the doc-comments at 80 chars and adds a doc-comment to SortServices. |
zyga
approved these changes
Feb 14, 2020
Contributor
zyga
left a comment
zyga
left a comment
There was a problem hiding this comment.
Funny. I added FileName to several App/Service/Timer/Socket types today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This eliminates the need to call this snippet of code everywhere. It also eliminates some imports of path/filepath.