Skip to content

Conversation

@jdstrand
Copy link

  • apparmor: allow read on @{PROC}/sys/fs/file-nr by default
  • seccomp: better document ioctl mediation
  • interfaces/desktop-legacy: allow org.gtk.GLib.PACRunner.Lookup()

@jdstrand jdstrand changed the title Misc small interface updates interfaces: misc small interface updates Jun 15, 2020
@jdstrand jdstrand requested a review from jhenstridge June 15, 2020 22:00
@jdstrand
Copy link
Author

@jhenstridge - can you comment on 65323a9 and its location in desktop-legacy?

@mvo5 mvo5 merged commit 96abd5e into canonical:master Jun 16, 2020
path=/org/gtk/GLib/PACRunner
interface=org.gtk.GLib.PACRunner
member=Lookup
peer=(label=unconfined),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fairly safe to add to desktop-legacy. We probably want to direct people towards org.freedesktop.portal.ProxyResolver instead though.

If a confined app is hitting this D-Bus API, then it is using the libgiognomeproxy GProxyResolver backend, and has gsettings access to know that proxy auto config has been enabled.

If instead portal support is enabled, the portal backend for GProxyResolver is used. This one doesn't need to have gsettings plugged, and delegates all proxy requests to xdg-desktop-portal, which in turn calls the standard GProxyResolver backend.

As far as security concerns over the org.gtk.GLib.PACRunner interface specifically, the client can ask the unconfined glib-pacrunner executable to execute an arbitrary file://, http://, or https:// URL as JavaScript and pass in an arbitrary URL as a function argument. With that said, the JS is run within mozjs's web sandbox so should be fairly safe.

Copy link
Author

@jdstrand jdstrand Jun 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kenvandine - fyi, this came up due to a snap-store bug: https://bugs.launchpad.net/snapd/+bug/1871364 and based on @jhenstridge comments, it seems like it needs to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants