fix: reinstate default bundle create behaviour #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Robinson Hodges <andrew.robinsonhodges@snyk.io>
# Conflicts: # bundle/bundle_manager.go # internal/deepcode/helpers.go # internal/util/hash.go
…s is now optional
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) ✅ code/snyk check is complete. No issues have been found. (View Details) |
bastiandoetsch
approved these changes
Sep 10, 2025
andrewrobinsonhodges-snyk
deleted the
feat/improve-bundle-performance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing the bundle Create method to create empty bundles broke AIBOM, as it needs access to the file contents without running a scan.
This PR introduces a new CreateEmpty method on the Bundle interface. Code scans use the new method (and so don't need to load files into memory), and AIBOM and other CLI commands can continue to use the old behaviour.
Checklist
🚨After having merged, please update the
snyk-lsand CLI go.mod to pull in latest client.