feat: add client for the workspace API [IDE-200] #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodora-sandu
force-pushed
the
feat/workspace-client
branch
from
e5b348f to
1308165
Compare
teodora-sandu
force-pushed
the
feat/workspace-client
branch
from
1308165 to
bf1a2c1
Compare
teodora-sandu
changed the title
teodora-sandu
force-pushed
the
feat/workspace-client
branch
from
4fcda0c to
3c437ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the workspace client for this API by using https://github.com/deepmap/oapi-codegen.
The way it works is we have hardcoded the version of the API in the Makefile and use the GitHub PAT provided via an environment variable to download all the specs required from the
workspac-servicerepo. The specs are ignored fromgitso never get committed. Then, because ofoapi-codegenproblems when referencing external references (from GitHub) and generating types for external references that do not have acomponentssection, we need to manipulate the specs to follow these conventions.So
make download-apisdownloads the specs and manipulates them.Then
make generategenerates the types for all the specs and the client for the workspace API.