Skip to content

fix: include code quality issues #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2024
Merged

fix: include code quality issues #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
506bf63
fix: include fake code quality issues
teodora-sandu Apr 2, 2024
54dbf6d
chore: add gitleaks ignores for fake data
teodora-sandu Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ workflows:
name: Scan repository for secrets
context:
- snyk-bot-slack
channel: team-ide
channel: dx-local-alerts
- security-scans:
name: Security Scans
context: code-client-go
Expand Down
5 changes: 4 additions & 1 deletion .gitleaksignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
# add false positives here
506bf6346668e6e0bac9b9590ae559f49c20f910:internal/analysis/fake.json:generic-api-key:180
506bf6346668e6e0bac9b9590ae559f49c20f910:internal/analysis/fake.json:generic-api-key:245
506bf6346668e6e0bac9b9590ae559f49c20f910:internal/analysis/fake.json:generic-api-key:495
506bf6346668e6e0bac9b9590ae559f49c20f910:internal/analysis/fake.json:generic-api-key:560
2 changes: 1 addition & 1 deletion internal/analysis/analysis_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ func TestAnalysis_RunAnalysis(t *testing.T) {
actual, err := analysis.RunAnalysis()
require.NoError(t, err)
assert.Equal(t, "COMPLETE", actual.Status)
assert.Contains(t, actual.Sarif.Runs[0].Results[0].Locations[0].PhysicalLocation.ArtifactLocation.URI, "src/main.ts")
assert.Contains(t, actual.Sarif.Runs[0].Results[0].Locations[0].PhysicalLocation.ArtifactLocation.URI, "scripts/db/migrations/20230811153738_add_generated_grouping_columns_to_collections_table.ts")
assert.Nil(t, actual.Sarif.Runs[0].Results[0].Suppressions)
assert.NotNil(t, actual.Sarif.Runs[0].Results[1].Suppressions)
assert.Len(t, actual.Sarif.Runs[0].Results[1].Suppressions, 1)
Expand Down
Loading