refactor: code scanner signature [IDE-195] #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodora-sandu
force-pushed
the
refactor/code-scanner-signature
branch
from
1a29cdc to
494b4ce
Compare
teodora-sandu
force-pushed
the
refactor/code-scanner-signature
branch
from
a552889 to
494b4ce
Compare
teodora-sandu
force-pushed
the
refactor/http-client
branch
from
bc53a53 to
95364d6
Compare
teodora-sandu
force-pushed
the
refactor/code-scanner-signature
branch
4 times, most recently
from
7d4f479 to
b20292c
Compare
acke
approved these changes
Apr 8, 2024
| "github.com/rs/zerolog" | ||
|
|
||
| "github.com/snyk/code-client-go/deepcode" | ||
| "github.com/snyk/code-client-go/internal/deepcode" |
acke
approved these changes
Apr 8, 2024
acke
approved these changes
Apr 8, 2024
teodora-sandu
force-pushed
the
refactor/http-client
branch
from
95364d6 to
a3a873b
Compare
teodora-sandu
force-pushed
the
refactor/http-client
branch
from
a3a873b to
dc43572
Compare
teodora-sandu
force-pushed
the
refactor/code-scanner-signature
branch
from
b20292c to
d782ad9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #22.
This refactors the Code Scanner interface so that it's easier to use in
snyk-lsand we don't need to expose unnecessary clients for the consumers of the library.Now, the HTTP client, logger, config, instrumentor, and error reporter are the only parts of this flow that need to be different between the CLI and IDE (see snyk/snyk-ls#484).
As a result, the
bundleanddeepcodepackages thus can be moved tointernal/since no one needs to use it directly.It's easier to review commit by commit.
Tested it with
snyk-lsandsnyk-intellij-pluginby following https://snyksec.atlassian.net/wiki/spaces/IDE/pages/1966866488/How+to+setup+development+for+Consistent+Ignores