Skip to content

fix: remove usage of global logger #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix: remove usage of global logger #26

merged 1 commit into from
Apr 9, 2024

Conversation

@PeterSchafer
Copy link
Contributor

@PeterSchafer PeterSchafer commented Apr 8, 2024

replaced the usage of the global logger by an instance of a parameterized logger.

@PeterSchafer PeterSchafer requested a review from a team as a code owner April 8, 2024 16:32
@github-actions github-actions bot added the fix label Apr 8, 2024
teodora-sandu
teodora-sandu approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@teodora-sandu teodora-sandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PeterSchafer PeterSchafer merged commit 399e577 into main Apr 9, 2024
@PeterSchafer PeterSchafer deleted the fix/global_logger_usage branch April 9, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@teodora-sandu teodora-sandu teodora-sandu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PeterSchafer @teodora-sandu