refactor: use the function options pattern for external functions #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acke
approved these changes
Apr 18, 2024
Contributor
acke
left a comment
acke
left a comment
There was a problem hiding this comment.
The functional options pattern change is so cool!
Patch looks great!
teodora-sandu
force-pushed
the
refactor/function-options-pattern
branch
from
38a0aab to
6dc1d3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the external functions exposed by this library to use the function options pattern.
Left out the
configandhttpClientfrom the function options pattern for the scanner because there isn't a logical fallback for them. Also left out thehttpClientFactoryfor the same reason.