refactor: http logger option #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodora-sandu
force-pushed
the
refactor/http-logger-option
branch
from
9ae2ace to
e1b33cc
Compare
http/http.go
Outdated
| copyReqBody = io.NopCloser(bytes.NewBuffer(reqBuf)) | ||
| req.Body = reqBody | ||
| s.logger.Debug().Str("url", req.URL.String()).Str("snyk-request-id", requestId).Str("requestBody", string(reqBuf)).Msg("SEND TO REMOTE") | ||
| s.logger.Debug().Str("method", req.Method).Str("url", req.URL.String()).Str("snyk-request-id", requestId).Str("requestBody", string(reqBuf)).Msg("SEND TO REMOTE") |
Contributor
There was a problem hiding this comment.
this would overwrite the "method" attribute in the logger defined in line 129. Maybe call it "requestMethod"?
Also I'd advise against outputting the requestBody in debug mode - this would log the complete repository source code, when uploading files for analysis.
Contributor
Author
There was a problem hiding this comment.
Ah good point, I've just updated the PR to do what you suggested. Could you have another look please?
teodora-sandu
force-pushed
the
refactor/http-logger-option
branch
from
e1b33cc to
c649e04
Compare
bastiandoetsch
approved these changes
Apr 19, 2024
teodora-sandu
force-pushed
the
refactor/http-logger-option
branch
from
c649e04 to
1dfe08c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot to re-init the error reporter logger with the provided logger and while I was looking at the http client I wanted to refactor the logic a bit so it's easier to follow.