-
Notifications
You must be signed in to change notification settings - Fork 568
Fix possible DOS and small changes to timeouts #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Edit: Don't merge this yet. I'll create a new pull request. |
|
you don't have to create a new PR if you want to overwritethe commits |
|
Ah right. I'll do that then. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have to initialize them as null ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because that will a) make it clear to the programmer what kinds of attributes this class will have and b) improve performance because the VM will not have to change the internal class at runtime.
|
Now I'm done. |
Fix possible DOS and small changes to timeouts
|
This broke 0.8 - reverting to |
|
Ah. I didn't know you're trying to be backwards compatible that far. |
|
There's a lot of people on 0.8 still |
Fix possible DOS and small changes to timeouts
README: remove outdated browserbuild reference
By sending many upgrade event a client could possible create a lot of intervals without the old ones having a chance of being cleared. I also added the intervals to the constructor and made it use setImmediate instead of process.nextTick.