Fixed endless reconnection loop #1231
Conversation
* development: update changelog/readme for 15.1 update changelog fix socketio#1178 expose Starscream WebSocket enableSOCKSProxy option to socket.io-client-swift options
|
How exactly is this fixing it? I guess not dispatching again to the engineQueue is better, but I'm not seeing how this would fix anything per se. |
|
I can't tell you exact sequence of events right now, but the basic idea is as follows. Method '_connect' is executed on serial 'engineQueue'. 'disconnect' is called at the beginning of '_connect' method and dispatches '_disconnect' to the same 'engineQueue'. So '_disconnect' isn't executed immediately, but is being dispatched for a later execution. After that '_connect' method continues its execution (probably creates some connection-related stuff). When '_connect' returns, previously dispatched '_disconnect' is being executed (and probably kills some connection-related stuff created by '_connect'). So calling '_disconnect' instead of 'disconnect' ensures proper ordering of events |
2 participants
Fix for:
#1016
#918
#913
#909
#784