Transport type XHRPolling: Method check() is missing.

[gabber7]

Firebug error in method getTransport():
io.Transport[transport].check is not a function

After adding the two methods check() and xdomainCheck(), that were removed in commit 74fd94f, XHRPolling works again.

[3rd-Eden]

Which version of Socket.IO are you using, and which version of firefox? I'm wondering this because the XHRPolling transport inherits from the xhr transport which does have those methods in the prototype: https://github.com/LearnBoost/socket.io-client/blob/master/lib/transports/xhr.js#L187-206

Also does this issue still occur in the current master repository

[gabber7]

The problem occurs in Firefox 5.0 on Ubuntu 11.04 with socket.io-client from current master.

[3rd-Eden]

Are you connecting cross domain, cross port?

[gabber7]

Yes, both. SSL is enabled.

[gabber7]

The problem only occurs with xhr-polling enabled. When I'm setting jsonp-polling as the only transport type, it works in all browsers.

[3rd-Eden]

Thanks for the information, that gives a lead on where we should dig if we want to reproduce this issue.

[gabber7]

The problem also occurs without SSL. It seems that the class XHRPolling does not inherit the two mentioned methods of XHR properly.

[3rd-Eden]

I think this is caused by 15ee167ca92c6a because the .check and .xdomainCheck are not prototypes, they are properties that are attached on the object.

@guille did you test change (see commit above) as you also removed the util.merge

So it seems a

util.inherit = function (ctor, ctor2) {
    function f() {};
    f.prototype = ctor2.prototype;
    util.merge(ctor, ctor2);
    ctor.prototype = new f;
  };

would fix this