-
Notifications
You must be signed in to change notification settings - Fork 3k
Added preliminary support for socket.io-client to work from node.js #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
-1 this adds unneeded bloat to the regular client |
|
If we simply add |
|
+1 we need #208 to be fixed! |
|
+1, need to test some socket.io code! :) Added |
|
Personally, I don't like the way this patch works. Especially the code it adds to make /lib/socket.js working on the server. I personally prefer on fixing the root issues instead of adding a hack. The main problems are that we expect that certain variables are global and always available, this code should just add a check to see that is the case. As adding node support seems to be a hot topic today I decided to roll my own patch based on the work of Joseph. This creates a much more flexible code base and attempts to fix the root issues that we have when we require client side code in node. |
|
Much better indeed, less is more. |
Updated package.json Fixed ineffecient document check
|
#274 landed with nodejs support |
|
Yay for testing! Thanks a lot. |
|
Great stuff - thats much better, 3rd-Eden. :) |
|
Hi, |
I've fixed a few bugs and stubbed out some code to make the socket.io-client work in nodejs.