Use prefix of this itself

[Lellansin]

It's better to use this.prefix than an upper scope's prefix.

[objectiveSee]

I was thinking we could add a proto function that is the sole place responsible for generating a channel name, such as :

Redis.prototype.channelName = function(room){
  var channelName = this.prefix + '#' + this.nsp.name + '#';
  if ( room ) {
    channelName +=  room + '#';
  }
  return channelName;
}

There are currently 5 or so places in the code that do string concatenation to form Redis channel names.

[nkzawa]

I think we can just append namespace to prefix in the first place like

this.prefix = prefix + '#' + this.nsp.name + '#';

[Lellansin]

@nkzawa Looks good 👍

[objectiveSee]

@Lellansin can you resolve the merge conflicts?