Skip to content

Remove already inheriged methods from Notify::Pipe #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2020
Merged

Remove already inheriged methods from Notify::Pipe #6

merged 1 commit into from
Apr 2, 2020

Conversation

@j-a-m-l
Copy link
Contributor

@j-a-m-l j-a-m-l commented Mar 14, 2020

These methods are duplicated from Notify::Client, which is the parent of Notify::Pipe.

@coveralls
Copy link

coveralls commented Mar 14, 2020

Coverage Status

Coverage increased (+0.9%) to 80.029% when pulling b8d09f2 on j-a-m-l:refactor-pipe into 45a2f5d on socketry:master.

olleolleolle
olleolleolle approved these changes Mar 14, 2020
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're absolutely right, they're the same.

@ioquatix ioquatix merged commit b4d53f2 into socketry:master Apr 2, 2020
@ioquatix
Copy link
Member

ioquatix commented Apr 2, 2020

Thanks!

@j-a-m-l
Copy link
Contributor Author

j-a-m-l commented Apr 4, 2020

Thanks to you for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@j-a-m-l @coveralls @ioquatix @olleolleolle